telegram icon indicating copy to clipboard operation
telegram copied to clipboard

Fixed reply in notification deminiaturizing window

Open Lukakva opened this issue 8 years ago • 8 comments

Using reply feature on the notification was deminiaturizing the main window, even if the user was on other application, or even in full screen view.

Things get especially weird when in full screen mode. The window deminiaturizes and covers the screen and then goes into the background.

telegram

Lukakva avatar Feb 01 '17 11:02 Lukakva

NSUserNotificationActivationTypeReplied will cause crash in 10.8 after receive any message. // NSUserNotificationActivationTypeReplied NS_AVAILABLE(10_9, NA) = 3,

overtake avatar Feb 01 '17 11:02 overtake

is this something configurable? I for one think it's nice that the chat doesn't show after I reply. I think that upon clicking on the notification you should go to the chat (but I believe this dismisses the notification atm).

antonsteenvoorden avatar May 16 '17 14:05 antonsteenvoorden

@antonsteenvoorden 🤔

overtake avatar May 16 '17 14:05 overtake

@antonsteenvoorden added some changes to this code. now after reply window not appearing

overtake avatar May 16 '17 14:05 overtake

If I would have wanted to go to the chat, I would cmd tab to it, or just click the telegram icon 😜. I like that when I hit reply I can continue doing what I was doing.

Something else that is useful tho is to remove the unread messages counter after hitting reply

Im just sharing my opinion, I have no authority.

antonsteenvoorden avatar May 16 '17 14:05 antonsteenvoorden

Will this open the conversation the notification came from? or just open the application?

antonsteenvoorden avatar May 16 '17 14:05 antonsteenvoorden

@antonsteenvoorden If you just click the notification, it opens the chat.

When you click Reply on the notification, it replies to the chat. The problem was that when you used reply option, it would still open the chat, whereas it would be much better if you could just continue what you were doing (exactly what you said).

Lukakva avatar May 16 '17 14:05 Lukakva

im glad you agree. is the owner still active? since this PR has been around for some time now..

antonsteenvoorden avatar May 16 '17 14:05 antonsteenvoorden