tutor-indigo icon indicating copy to clipboard operation
tutor-indigo copied to clipboard

fix: ora grading iframe dark frame issue

Open HammadYousaf01 opened this issue 9 months ago • 1 comments

Fixed the dark theme issue within ora grading. The only solution I could come up with was to change the background color instead of the text color. The issue was that an iframe within an iframe didn't allow us to target styles.

Fixes https://github.com/overhangio/tutor-indigo/issues/120

WYSIWYG editor fix

HammadYousaf01 avatar Mar 25 '25 09:03 HammadYousaf01

@HammadYousaf01 Please add appropriate screenshots.

DawoudSheraz avatar Mar 28 '25 06:03 DawoudSheraz

The current response editor shows up with a black background during dark theme but the font is also black which makes readability very difficult.

We now change the background to a light gray colour instead. Ideally, we would change the font to a white colour for consistency with the rest of the theme however, the response editor is an iframe embedded inside another iframe. Due to browser security controls, we cannot access the DOM content of these iframes and thus cannot modify the text colour.

Here is an example of how it looks now:

image

This new colour is also WCAG compliant with our background dark colours.

image image

Danyal-Faheem avatar Jul 03 '25 13:07 Danyal-Faheem