overhangio
Toogle Theme button accessible using keyboard and Enter press
Description: Made Toggle Theme button keyboard accessible in top nav bar. Ticket: https://tree.taiga.io/project/zaraahmed-tutor-indigo-accessibility/us/110
LGTM! I've tested it locally, and everything seems to be working fine.
Thanks for your contribution! This works as intended. Could you please add a changelog entry?
do you think we have to add change logs for each accessibility PR? there are more than 100 very small things are there TBD.
That’s a fair point. We could bundle those changes together to minimize repeated reviews and testing overhead, and also reduce the number of changelog entries.
This PR has been finalised from my end please let me know if you have any suggestions/recommendations.
On Tue, 29 Apr 2025 at 2:37 PM, Syed Muhammad Dawoud Sheraz Ali < @.***> wrote:
DawoudSheraz left a comment (overhangio/tutor-indigo#134) https://github.com/overhangio/tutor-indigo/pull/134#issuecomment-2838026234
@zubairshakoorarbisoft https://github.com/zubairshakoorarbisoft Any update on this PR? Thanks
— Reply to this email directly, view it on GitHub https://github.com/overhangio/tutor-indigo/pull/134#issuecomment-2838026234, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANX4P4VUDNLZT6SC6CRMWD3235B4DAVCNFSM6AAAAABZIDMXKWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMZYGAZDMMRTGQ . You are receiving this because you were mentioned.Message ID: @.***>
--
The content of this email and attachment(s) are confidential and intended solely for the recipient(s) specified in the message. If you received this email by error, please alert the sender by replying to this email and follow with its deletion, so that we can ensure such an error does not occur in future. If you are not the intended recipient, you are strictly prohibited to use, copy, disseminate or store this email or its attachment(s).
This PR has been finalised from my end please let me know if you have any suggestions/recommendations.
@zubairshakoorarbisoft, then we can conclude this pull request. Kindly add the changelog entry. For the rest of the issues, I think we should proceed with a single pull request to make it easier to test and to minimize noise in changelog.
This PR has been finalised from my end please let me know if you have any suggestions/recommendations.
@zubairshakoorarbisoft, then we can conclude this pull request. Kindly add the changelog entry. For the rest of the issues, I think we should proceed with a single pull request to make it easier to test and to minimize noise in changelog.
@HammadYousaf01 We decided to create a parent Tutor Indigo issue to track all related accessibility issues, as combining everything into a single PR would become difficult to manage. Regarding the changelog entry, one approach could be to consolidate changelog updates from all relevant PRs across repositories and include them together in a single entry. CC: @regisb
Regarding the changelog entry, one approach could be to consolidate changelog updates from all relevant PRs across repositories and include them together in a single entry.
This is reasonable. That means:
- Create a changelog entry for every PR, with different content.
- At release time, edit the changelog entries to make them more consistent.
