Results 141 comments of Jun Luo

I plan to release the stable version 1.0.0 with the launch of Protocol 22.

If approved, I will submit a PR. I haven't submitted a PR here in a long time, so I want to start with a small PR to refresh my memory...

Hi @Hannsek, thank you for this information. I will take some time to see if I can align Stellar's process as closely as possible with the one in the image...

Hi @Hannsek For a Payment transaction, the message consists of the following two parts: * https://github.com/trezor/trezor-firmware/blob/9fc0c5d82b16f205e20bec6efceb91189dcac59d/common/protob/messages-stellar.proto#L45-L72 * https://github.com/trezor/trezor-firmware/blob/9fc0c5d82b16f205e20bec6efceb91189dcac59d/common/protob/messages-stellar.proto#L45-L72 Below is my explanation for each field: ### `StellarSignTx` * `address_n`: Used...

> Is this really necessary to display it? What value it brings to the users? I believe that in most cases, it is not important for the user. However, if...

> How often is `memo` used when doing standard operations (not sending to exchange)? I am wondering if we should use _hard_ or _soft_ warning if memo is not set....

Hi @Hannsek Let's take `USDC` as an example. If a user wants to hold `USDC` in their account, they first need to trust `USDC:GA5ZSEJYB37JRC5AVCIA5MOP4RHTM335X2KGX3IHOJAPP5RE34K4KZVN`. This is generally a **one-time** operation;...

Hi @Hannsek Q1: Payment Operation - Asset Info Display For a Payment operation, the asset information is currently shown on the last page. A single transaction can include multiple send...

Hi @Hannsek, The design looks great! I do have a couple of suggestions, though. First, I think `Signing with` would be a better phrase to use here. Also, if `tx.source_account`...