NeoSolarized icon indicating copy to clipboard operation
NeoSolarized copied to clipboard

Some colors are wrong on neovim 0.10

Open lucc opened this issue 1 year ago • 3 comments

With the release of neovim 0.10 the default colorscheme in neovim was changed. It seems that NeoSolarized picks up some of the default colors as some colors do not match the solarized theme when using neovim v0.10.

with neovim 0.10:

2024-05-21-121920_508x296_scrot

with neovim 0.9.5:

2024-05-21-122037_508x296_scrot

lucc avatar May 21 '24 10:05 lucc

Same problem here

xanderdunn avatar May 25 '24 00:05 xanderdunn

I switched to https://github.com/maxmx03/solarized.nvim

Then I had to adjust some settings to make it look the same:

vim.o.background = 'dark'

require('solarized').setup({
    transparent = false,
    palette = 'solarized',
    styles = {
      keywords = { bold = false },
    },
    highlights = {
      KeyWord = { fg = '#859900' },
      Delimiter = { fg = '#dc322f' },
      Number = { fg = '#2aa198' }
    },
})

vim.cmd.colorscheme 'solarized'

hasufell avatar Jul 18 '24 08:07 hasufell

neovim 0.10 changelog:

Default color scheme has been updated to be "Nvim branded" and accessible. [...] This also might result into some color schemes looking differently due to them relying on implicit assumptions about how highlight groups are defined by default. To account for this, define all attributes of highlight groups explicitly. Alternatively, use :colorscheme vim or :source $VIMRUNTIME/colors/vim.lua to restore previous definitions.

This sufficed for me:

@@ -134,6 +134,11 @@
 if exists("syntax_on")
   syntax reset
 endif
+if has('nvim-0.10')
+  " Pending explicit highlight-group definitions:
+  " https://github.com/overcache/NeoSolarized/issues/34
+  colorscheme vim
+endif
 let colors_name = "NeoSolarized"

 "}}}

I don't know enough about highlight groups—namely, which ones NeoSolarized left implicit—to pursue the correct fix.

Goorzhel avatar Nov 30 '24 02:11 Goorzhel