GraphQLBundle icon indicating copy to clipboard operation
GraphQLBundle copied to clipboard

Add the concept of "validation_mode"

Open joesaunderson opened this issue 1 year ago • 3 comments

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Documented? yes
Fixed tickets N/A
License MIT

Adds the concept of validation_mode at the default config level.

joesaunderson avatar May 14 '24 17:05 joesaunderson

Excellent @joesaunderson! You are on the right track! Do you think it would be possible to also be able to manage the validation mode on the object itself (if it's too complicated, we'll try to implement in a future release). If you can also add the test (with the same object applying both modes and validate the output).

Vincz avatar May 17 '24 16:05 Vincz

Hello @joesaunderson and @Vincz , is it possible to move his PR forward as it solves problem introduced in https://github.com/overblog/GraphQLBundle/pull/1184 ? We are locked on version 1.3.2 and are waiting for this to be fixed. Thank you.

TomasLudvik avatar Sep 17 '24 09:09 TomasLudvik

I won't have the time I'm afraid, but someone can take this base and make the changes @Vincz suggests.

joesaunderson avatar Sep 17 '24 09:09 joesaunderson

@TomasLudvik #1184 has been rolled back in #1214

murtukov avatar Nov 04 '25 19:11 murtukov

Closing this PR because it was opened based on the incorrect assumption that the validator asserts optional fields. In reality, if an optional field is omitted, it isn’t validated unless it’s explicitly marked with Assert\NotBlank.

murtukov avatar Nov 04 '25 19:11 murtukov