GraphQLBundle icon indicating copy to clipboard operation
GraphQLBundle copied to clipboard

Published 20 hours ago • verified publisher icon overblog

fix: Fix the memory leak

Open theofidry opened this issue 1 year ago • 3 comments

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? could not check
Documented? no
Fixed tickets #721
License MIT

Follow up of my comment.

I cannot investigate further, but my guess is that exceptions are not cheap objects. When creating an exception you also capture the context and stack trace which means that even if the extension is unsued:

  • It slows down the program because instantiating it is not cheap.
  • May prevent some objects to be garbage collected because referenced in the exception.

theofidry avatar May 02 '23 13:05 theofidry

Hi @theofidry! Can you check the tests please? Don't have time to dig into this atm but it seems to break the tests suite: https://github.com/overblog/GraphQLBundle/pull/1119/checks

Thanks!

Vincz avatar May 03 '23 06:05 Vincz

Hi @theofidry! Any update on this topic? Thanks!

Vincz avatar May 29 '23 13:05 Vincz

Sorry will try to come back to this in a near future

theofidry avatar Sep 20 '23 22:09 theofidry