bun icon indicating copy to clipboard operation
bun copied to clipboard

Published 20 hours ago • verified publisher icon oven-sh

7530 add http.server response attribute header

Open sirenkovladd opened this issue 1 year ago • 2 comments

What does this PR do?

added support ServerResponse._header full support light-my-request fixes: https://github.com/oven-sh/bun/issues/7530

  • [ ] Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • [X] Code changes

How did you verify your code works?

  • [X] I included a test for the new code, or existing tests cover it
  • [X] I ran my tests locally and they pass (bun-debug test test-file-name.test)
  • [X] I ran bun fmt

sirenkovladd avatar Dec 14 '23 11:12 sirenkovladd

Node code: https://github.com/nodejs/node/blob/f820efe0851dd3c64d673156b037ce7e8648fd81/lib/_http_outgoing.js#L586

jdalton avatar Jan 22 '24 20:01 jdalton

https://discord.com/channels/876711213126520882/888839314056839309/1187586872172621935

Jarred: This one should probably be done in native code. It's going to add quite a bit of overhead

sirenkovladd avatar Jan 22 '24 23:01 sirenkovladd