bun icon indicating copy to clipboard operation
bun copied to clipboard

some work on supporting `piscina`

Open alii opened this issue 5 months ago โ€ข 2 comments
trafficstars

What does this PR do?

Fixes #19924 Fixes #13218

CleanShot 2025-05-27 at 14 58 41@2x

  • [ ] Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • [x] Code changes

How did you verify your code works?

third party test (but will likely need to do more since there are worker related changes)

alii avatar May 27 '25 21:05 alii

Updated 4:21 PM PT - Oct 20th, 2025

:x: @alii, your commit a45c2632c3b38a16fdf710d36369bbd54861c94d has 1 failures in Build #29763 (All Failures):


๐Ÿงช ย  To try this PR locally:

bunx bun-pr 19940

That installs a local version of the PR into your bun-19940 executable, so you can run:

bun-19940 --bun

robobun avatar May 27 '25 21:05 robobun

This assertion failure in test-worker-message-port-transfer-terminate is interesting: https://buildkite.com/bun/bun/builds/18199#01974255-d25e-4706-8891-290500bfd29b/2013-2014

Trying to repro

190n avatar Jun 06 '25 19:06 190n

[!IMPORTANT]

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

โœจ Finishing Touches
๐Ÿงช Generate unit tests
  • [ ] Create PR with unit tests
  • [ ] Post copyable unit tests in a comment
  • [ ] Commit unit tests in branch ali/piscina

๐Ÿชง Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Aug 30 '25 00:08 coderabbitai[bot]