posenet-for-installations icon indicating copy to clipboard operation
posenet-for-installations copied to clipboard

Add comment to client models.ts checkpoints architecture oddity

Open mncharity opened this issue 6 years ago • 1 comments

client/src/models.ts currently says:

  1.01: {
    url: BASE_URL + 'mobilenet_v1_101/',
    architecture: posenet.mobileNetArchitectures[100]
  },
  1.0: {
    url: BASE_URL + 'mobilenet_v1_100/',
    architecture: posenet.mobileNetArchitectures[100]
  },
  0.75: {
    url: BASE_URL + 'mobilenet_v1_075/',
    architecture: posenet.mobileNetArchitectures[75]
  },

The 1.01 architecture 100 is correct, but has the look of a typo, which can trigger review. So perhaps add a reassuring comment?

    architecture: posenet.mobileNetArchitectures[100] // same as 1.0

Thanks for your work.

mncharity avatar Oct 10 '18 15:10 mncharity

Yes this is correct. Feel free to submit a PR :)

oveddan avatar Oct 10 '18 19:10 oveddan