scribe icon indicating copy to clipboard operation
scribe copied to clipboard

Better benchmarks

Open darkfrog26 opened this issue 6 years ago • 7 comments

1.) Better tooling to expose performance flaws 2.) Additional benchmarks to show more features of Scribe 3.) A library to generate graphical reports on the benchmark results

darkfrog26 avatar Jun 21 '18 15:06 darkfrog26

Though I've added some additional benchmarking support, this should be an on-going process. Moving out of 2.6 release.

darkfrog26 avatar Aug 27 '18 18:08 darkfrog26

Could you also please include a Scala Native comparison with slogging (https://github.com/jokade/slogging)?

Thanks!

david-bouyssie avatar Jul 24 '19 11:07 david-bouyssie

@david-bouyssie, I'd be happy to, but this is way down on my priority list. If you'd be interested in contributing a PR I'd absolutely include the results in the next benchmark results.

darkfrog26 avatar Jul 25 '19 01:07 darkfrog26

Not a high priority neither on my side, it was just a suggestion for your next iteration. Thanks ;-)

david-bouyssie avatar Jul 25 '19 07:07 david-bouyssie

Scribe wins over Slogging for the name alone. :-p

darkfrog26 avatar Jul 25 '19 12:07 darkfrog26

Great work with the library. I think the current benchmarks might be a bit outdated. The benchmark numbers would be more complete if scribe was benchmarked against log4j's disruptor-based async logger.

jvican avatar May 12 '20 23:05 jvican

@jvican that's a great point. Any chance you have any interest in putting together a PR to represent that well? Where possible I prefer not to be the one to implement competitor loggers to avoid being accused of slanting in Scribe's favor.

darkfrog26 avatar May 13 '20 13:05 darkfrog26