vertx-oas icon indicating copy to clipboard operation
vertx-oas copied to clipboard

Published 20 hours ago • verified publisher icon outofcoffee

Suggestion make generator method non-static

Open dhoffer opened this issue 7 years ago • 2 comments

I'd like to have RouterSpecGenerator not have static method so we can mock this in our unit tests.

dhoffer avatar Feb 02 '18 21:02 dhoffer

Thanks for the suggestion, @dhoffer.

I'm happy to make it non-static; but might retain a static builder method for others who want to use it. WDYT?

outofcoffee avatar Feb 03 '18 18:02 outofcoffee

Sure if you can do both that is fine. We just want to be able to mock any method we call.

On Sat, Feb 3, 2018 at 11:55 AM, Pete Cornish [email protected] wrote:

Thanks for the suggestion, @dhoffer https://github.com/dhoffer.

I'm happy to make it non-static; but might retain a static builder method for others who want to use it. WDYT?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/outofcoffee/vertx-oas/issues/3#issuecomment-362844777, or mute the thread https://github.com/notifications/unsubscribe-auth/ABfwrw1Ku3SbBWFKjJgQ9Ac2fFp9JONuks5tRKuxgaJpZM4R3xxz .

dhoffer avatar Feb 03 '18 22:02 dhoffer