rich-markdown-editor icon indicating copy to clipboard operation
rich-markdown-editor copied to clipboard

onChange called on init when view == null

Open fedotxxl opened this issue 2 years ago • 1 comments

  1. Create h1 opened, save
  2. Open, collapse h1, don't save
  3. Refresh

In this case, h1 state will be read from localStorage, differ from JSON persisted state and onChange callback triggered. The problem is that view is not ready and getting value will result to Cannot read properties of undefined (reading 'state')

Solution add this.view check?

  handleChange = () => {
    if (!this.props.onChange || !this.view) return;

    this.props.onChange(() => {
      return this.value();
    });
  };

fedotxxl avatar Dec 25 '21 15:12 fedotxxl

I am getting the same error occasionally. And yes, it looks like it has something to do with h1 getting collapsed.

BR, Carsten

came avatar Dec 27 '21 20:12 came