outline icon indicating copy to clipboard operation
outline copied to clipboard

Add optional S3 PUT uploads + per-folder reports for fashion model

Open oleksandr-diudiun opened this issue 1 month ago • 5 comments

@tommoor about #10609

  1. add an opt-in S3_SUPPORT_PUT_UPLOAD flag that switches presigned uploads from POST to PUT for S3-compatible backends like Cloudflare R2

  2. propagate the new upload metadata through FileStorage.getPresignedPost, the attachments API, and the client uploader so PUT flows work transparently

oleksandr-diudiun avatar Nov 16 '25 14:11 oleksandr-diudiun

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Nov 16 '25 14:11 CLAassistant

I don't want to maintain additional configuration for this. S3, Minio, etc also supports the PUT verb for uploads from JS so I think as long as the local file storage endpoint is updated to support both that we can change the default to always be PUT and it will be fully backwards compatible without additional config or code branches.

tommoor avatar Nov 16 '25 14:11 tommoor

I don't want to maintain additional configuration for this. S3, Minio, etc also supports the PUT verb for uploads from JS so I think as long as the local file storage endpoint is updated to support both that we can change the default to always be PUT and it will be fully backwards compatible without additional config or code branches.

Totally agree with you, in this pull request it is optional feature lest say "experimental" optional feature so how about to try it out with official build and I will migrate normally from AWS to R2 my outlines and then will invest little bit time on next week to test it with other S3 services to be sure that it can be really simplified there and then will send one more pull request .

oleksandr-diudiun avatar Nov 16 '25 14:11 oleksandr-diudiun

Sounds good, I won't merge until we have that simplified solution though

tommoor avatar Nov 22 '25 11:11 tommoor

@oleksandr-diudiun any update / luck with other S3 services? i'd be down to test this with Backblaze B2 if needed

sapphies avatar Dec 04 '25 22:12 sapphies