nova-menu-builder icon indicating copy to clipboard operation
nova-menu-builder copied to clipboard

Doesn't work with Nova v5

Open pazazdigital opened this issue 1 year ago • 4 comments

Errors in IDE when adding to tools array Undefined type 'Outl1ne\MenuBuilder\MenuBuilder'.

Also the following when migrating:

  INFO  Running migrations.  

  2019_11_08_000000_create_menus_table 
   Symfony\Component\ErrorHandler\Error\FatalError 

  Class OptimistDigital\MenuBuilder\MenuBuilder contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (Laravel\Nova\Tool::menu)

  at vendor/outl1ne/nova-menu-builder/src/MenuBuilder.php:8
      4▕ 
      5▕ use Laravel\Nova\Nova;
      6▕ use Laravel\Nova\Tool;
      7▕ 
  ➜   8▕ class MenuBuilder extends Tool
      9▕ {
     10▕     protected static $defaultLinkableModels = [
     11▕         \OptimistDigital\MenuBuilder\Classes\MenuItemStaticURL::class,
     12▕         \OptimistDigital\MenuBuilder\Classes\MenuItemText::class,


   Whoops\Exception\ErrorException 

  Class OptimistDigital\MenuBuilder\MenuBuilder contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (Laravel\Nova\Tool::menu)

  at vendor/outl1ne/nova-menu-builder/src/MenuBuilder.php:8
      4▕ 
      5▕ use Laravel\Nova\Nova;
      6▕ use Laravel\Nova\Tool;
      7▕ 
  ➜   8▕ class MenuBuilder extends Tool
      9▕ {
     10▕     protected static $defaultLinkableModels = [
     11▕         \OptimistDigital\MenuBuilder\Classes\MenuItemStaticURL::class,
     12▕         \OptimistDigital\MenuBuilder\Classes\MenuItemText::class,

      +1 vendor frames 

  2   [internal]:0
      Whoops\Run::handleShutdown()
      ```

pazazdigital avatar Dec 17 '24 17:12 pazazdigital

Seems work is ongoing to support V5

graphem avatar Jan 13 '25 15:01 graphem

Any update here?

fijeo avatar Feb 05 '25 11:02 fijeo

Hi @Tarpsvo is there any chance to have a release compatible with nova v5? Thanks a lot!

fsavina-akqa avatar Feb 05 '25 20:02 fsavina-akqa

@Tarpsvo ^

Jaspur avatar Mar 04 '25 08:03 Jaspur

@Tarpsvo any update on this?

jeroenInova avatar Jun 30 '25 10:06 jeroenInova

@KasparRosin Thanks for merging the PR and closing the issue! Do you know, when a release for the Nova v5 support is planned?

LuckyLukas98 avatar Sep 09 '25 09:09 LuckyLukas98

Oh right.. Totally slipped my mind! Released version 8.0.0.

KasparRosin avatar Sep 09 '25 13:09 KasparRosin

Let's see if all the changes work. Might need to come back to this still.

KasparRosin avatar Sep 09 '25 13:09 KasparRosin