nova-menu-builder icon indicating copy to clipboard operation
nova-menu-builder copied to clipboard

Allow icon to be customised through config

Open johnpuddephatt opened this issue 2 years ago • 3 comments

This change keeps the icon as it is by default, but would optionally allow it to be customised in the config file.

My reason for suggesting this change is that currently the icon is the same as that used by the nova settings package.

johnpuddephatt avatar Jul 02 '22 13:07 johnpuddephatt

Would it work for you, if instead there was a function, where you could provide the new icon during registration?

    public function tools()
    {
        return [
            MenuBuilder::make()
                ->title('Custom Title'),
                ->icon('another-icon'),
        ];
    }

KasparRosin avatar Jul 19 '22 10:07 KasparRosin

Keeps the config file less bloated since the tool is initiated only once anyways.

KasparRosin avatar Jul 19 '22 10:07 KasparRosin

Yes this works.

I would submit another PR but I don't know how to do what you're suggesting!

johnpuddephatt avatar Jul 21 '22 14:07 johnpuddephatt

Merged via #161

KasparRosin avatar Sep 05 '22 12:09 KasparRosin