metaflow-tools icon indicating copy to clipboard operation
metaflow-tools copied to clipboard

fix: prioritize user-specified env vars

Open nschmeller opened this issue 3 months ago • 0 comments

Currently, user-specified env vars are treated differently between the metaflow-service and metaflow-ui Helm charts.

In the metaflow-service Helm chart, user-specified env vars are placed after chart-specified env vars. In this case, K8s will treat them with priority based on order. However, in the metaflow-ui Helm chart, the chart-specified env vars are placed last, giving them priority. Besides being inconsistent, this is problematic as we want to set our own env vars that conflict with the chart-specified env vars (in this case, MF_METADATA_DB_USER and MF_METADATA_DB_PSWD).

This commit switches the layout of the metaflow-ui env vars to prioritize user-specified over chart-specified env vars.

metaflow-service layout: https://github.com/outerbounds/metaflow-tools/blob/d24572c0a1610410ff586f1cd87312edc1c34cf1/charts/metaflow/charts/metaflow-service/templates/deployment.yaml#L73-L75

metaflow-ui layout: https://github.com/outerbounds/metaflow-tools/blob/d24572c0a1610410ff586f1cd87312edc1c34cf1/charts/metaflow/charts/metaflow-ui/templates/backend_deployment.yaml#L51-L75

nschmeller avatar Sep 18 '25 20:09 nschmeller