neural_prophet icon indicating copy to clipboard operation
neural_prophet copied to clipboard

[feature] Mask seasonality on Sat/Sun when data frequency is Business days.

Open Haridut opened this issue 3 years ago • 3 comments

Is there a way to pass in a data frame without weekends for prediction? The predict function seems to be working only when we use make future data frame function and not when we use external data which doesn’t have weekends.

Haridut avatar Aug 06 '22 02:08 Haridut

Hi @Haridut Have you tried setting the frequency to "B" for business days only?

Yes, the data format for training and predicting should be the same.

ourownstory avatar Aug 10 '22 17:08 ourownstory

Using the "b" flag worked for me. @ourownstory, if I can hijack the question, is there a way to disable the intra-week seasonality when using business days? So when using business days, the seasonality is only calculated for the business days, and you would not see the Sat and Sun in the components plots.

erykml avatar Aug 19 '22 00:08 erykml

@erykml That is a great suggestion. We have not implemented such a masking, as there are many possible such special cases. However, Business days may be a prominent enough edge case to warrant a special masking. Would you like to contribute this feature?

ourownstory avatar Aug 23 '22 18:08 ourownstory