neural_prophet icon indicating copy to clipboard operation
neural_prophet copied to clipboard

Published 20 hours ago • verified publisher icon ourownstory

CodeQL Github Action Integration v1 expires in December 2022

Open noxan opened this issue 2 years ago • 2 comments

Read details here: https://github.blog/changelog/2022-04-27-code-scanning-deprecation-of-codeql-action-v1/

Required changes

  • Upgrade Github Action for CodeQL to v2 before December 2022
  • Template for CodeQL Github Action with latest version: https://github.com/github/codeql-action#usage

Should be a simple change, happy to help with a contribution.

noxan avatar Jun 28 '22 10:06 noxan

@noxan I was considering to drop this altogether, as it takes a long time, and as our package does not connect to the internet. Or do you think that v2 brings enough of a speed-up that it may be worth keeping?

ourownstory avatar Jun 28 '22 22:06 ourownstory

@ourownstory I could give it a try and see the effect. Otherwise how about integrating linters like flake8, isort, and possibly black in case we want unified code formatting?

noxan avatar Jul 29 '22 13:07 noxan

Fixed by commit https://github.com/ourownstory/neural_prophet/commit/534f8029fd852223b1234d2e4036db0cef02bb90

noxan avatar Aug 16 '22 21:08 noxan