vue3-infinite-loading icon indicating copy to clipboard operation
vue3-infinite-loading copied to clipboard

Fix a bug in InfiniteLoading.vue.

Open lanmaster53 opened this issue 2 years ago • 4 comments

Fixes a bug in InfiniteLoading.vue that causes the final load to jump to the top of the elements when top is true. Resolves issue #70.

lanmaster53 avatar Aug 17 '23 13:08 lanmaster53

Deploy Preview for vue3-infinite-loading-demo ready!

Name Link
Latest commit 17494dfedb2010286218b3c5f13f5261860010da
Latest deploy log https://app.netlify.com/sites/vue3-infinite-loading-demo/deploys/64e26cc9c466450008232b22
Deploy Preview https://deploy-preview-71--vue3-infinite-loading-demo.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Aug 17 '23 13:08 netlify[bot]

The complete function should be async.

oumoussa98 avatar Aug 19 '23 19:08 oumoussa98

It's not very DRY though. There are at least 2 places with the same 3 lines of code. You could create a function or method to handle this so you only have to write it once, then just call the method where needed. That's what I would have done here, but I wasn't sure where you would prefer that logic to be.

lanmaster53 avatar Aug 19 '23 23:08 lanmaster53

that would be better, that's how i would implement it something like so:

Screenshot 2023-08-20 at 14 21 28

and the updateScrollPosition being imported from the utils file.

oumoussa98 avatar Aug 20 '23 13:08 oumoussa98