Plugin uses `$ASDF_CONCURRENCY` and ignores perl_install options

Open hurricup opened this issue 2 years ago • 4 comments

It is expected that plugin will pass through options to the perl_install, not override them silently. It is not possible to pass -j option.

See also: asdf-vm/asdf#1097

Feb 28 '23 07:02 hurricup

@hurricup Thank you for this issue.

Sorry, I don't understand the intent of this issue, so let me ask a question.

The following code gets the ASDF_CONCURRENCY, https://github.com/ouest/asdf-perl/blob/master/bin/install#L12 The following code sets the build_args. https://github.com/ouest/asdf-perl/blob/master/bin/install#L22

Does this process mean there is a problem? Because of my poor English, I don't completely understand.

Mar 28 '23 01:03 ouest

It is unclear why the plugin need to override -j option I pass explicitly in the build_args

Mar 28 '23 03:03 hurricup

I see. Perhaps I understand. You mean you need to make these modifications, right? https://github.com/ouest/asdf-perl/pull/23

Mar 28 '23 04:03 ouest

I'm late in responding, but I responded with the following p-r. Please check. https://github.com/ouest/asdf-perl/pull/23

Apr 02 '23 06:04 ouest