CrewLink icon indicating copy to clipboard operation
CrewLink copied to clipboard

New features

Open TennyKs opened this issue 4 years ago • 10 comments

Add new feature :

  • When two imposters or more are in the same vent, they can speak to each other and no one can hear them.

Add new settings to the game, disabled by default :

  • Allows haunt : Dead players can speak to players who are still alive.
  • Global vents comms : When two imposters or more are in a vent (doesn't matter which one) they can speak to each other and no one can hear them.
  • Hearing Distance : Modify the Hearing distance in-game. If modified, crewlink must be reloaded. The distance is between 0 and 255.

Pull_request

TennyKs avatar Dec 08 '20 13:12 TennyKs

All of these must be controlled by the lobby host and synced across clients. I can't merge this PR until that's implemented.

ottomated avatar Dec 08 '20 16:12 ottomated

All of these must be controlled by the lobby host and synced across clients. I can't merge this PR until that's implemented.

Okay, and is this already implemented for some settings ? So we can use the same model.

TennyKs avatar Dec 08 '20 17:12 TennyKs

Make Crewlink able to be pinned to the top of all programs so it stays on top.

Bartschey avatar Dec 08 '20 19:12 Bartschey

All of these must be controlled by the lobby host and synced across clients. I can't merge this PR until that's implemented.

Okay, and is this already implemented for some settings ? So we can use the same model.

I think PR #235 would be a good model

Tothas avatar Dec 08 '20 21:12 Tothas

I see a couple spots in Settings where classes are named EaringInputProps and EaringInput, I'd fix those typos.

Do we want an option for haunting ALL living people? I feel like letting ghosts talk to living crewmates would almost always be broken and spoil the game immediately, as the impostor's identities can be given away almost instantly. I think I prefer only letting ghosts talk to living impostors, like the original idea (#25) and my open PR (#192) do it.

The rest of the changes look great though, thanks for doing these! 👍

Ornamus avatar Dec 08 '20 21:12 Ornamus

@Ornamus Oh yeah I forgot these typos, my bad. For the haunting option, I play with friends, and we find it very fun to still be able to talk to ghosts even when we can't see them. Of course, it's based on fair-play and nothing stop them to reveal the imposter's identity. But they can scare alive players and have small talks without ruining the game. So yeah, it's only for friends when you trust them to not say everything. This is what it's an option. And why not both ?

@Tothas The PR #235 is great, and as soon it's merged i with adapt this PR to use the servers settings.

TennyKs avatar Dec 08 '20 22:12 TennyKs

@TennyKs Fair point, I suppose since CrewLink is mainly used among friends that we can just rely on those groups to not abuse it amongst themselves! I support having options for both global haunting and impostor-only haunting then :)

Ornamus avatar Dec 08 '20 22:12 Ornamus

@Ornamus Perfect :) I'll wait the server settings then.

TennyKs avatar Dec 08 '20 23:12 TennyKs

@Ornamus

I suppose since CrewLink is mainly used among friends...

I'm not sure this is true. I mainly use CrewLink in public discords with randoms. I wouldn't trust them not to abuse a feature like this. But it sounds like the consensus is to make this server-settings driven by the host, which assuages my concerns.

Just something to consider.

notexplosive avatar Dec 18 '20 01:12 notexplosive

@Ornamus

I suppose since CrewLink is mainly used among friends...

I'm not sure this is true. I mainly use CrewLink in public discords with randoms. I wouldn't trust them not to abuse a feature like this. But it sounds like the consensus is to make this server-settings driven by the host, which assuages my concerns.

Just something to consider.

I mean, it's just as easy to unmute yourself on discord and call out the imposters. An option for hosts to enable haunting for just imposters or for everyone or not at all would eliminate this issue.

KadenBiel avatar Jan 03 '21 22:01 KadenBiel