CrewLink-server icon indicating copy to clipboard operation
CrewLink-server copied to clipboard

Heroku Deploy Button

Open micahima opened this issue 4 years ago • 2 comments

Not sure if this is just me but the Heroku button to deploy is not linked to the Crewlink template. It just links to a blank Heroku template. I got my server to work through Heroku but I had to pull the link from a youtube video.

micahima avatar Dec 13 '20 02:12 micahima

Yes, the Heroku button points to a blank Heroku template. [![Deploy](https://www.herokucdn.com/deploy/button.svg)](https://heroku.com/deploy)

Until it is fixed use this link: Deploy to Heroku

joshijai2 avatar Dec 13 '20 08:12 joshijai2

This change isn't needed. The button works as-is (for me at least). According to the Heroku documentation:

...If you don’t specify a template parameter, Heroku infers it from the location of the button using the referer header (this does not work with private GitHub repos, because no referer header is sent). This makes the button stable under forks of the repository.

I'm guessing that it's possible to set up a browser to not send referer headers, which would cause the Deploy to Heroku button to not work. Is that the case for you @micahima / @joshijai2?

I suggest closing this issue and pull request #67.

P.S. Today I learned that the word "referrer" is misspelled as "referer" in the official HTTP specification. Wow.

david-in-perth avatar Mar 25 '21 10:03 david-in-perth