Otto Kekäläinen

More info on how Debian scans the ABI: * https://manpages.debian.org/unstable/dpkg-dev/dpkg-gensymbols.1.en.html * https://manpages.debian.org/unstable/dpkg-dev/deb-symbols.5.en.html

I applied `-DCMAKE_BUILD_TYPE=Release` in https://salsa.debian.org/debian/rocksdb/-/merge_requests/3 and now build fails with: ``` /usr/bin/ld: CMakeFiles/db_bench.dir/tools/db_bench_tool.cc.o:(.data.rel.ro._ZTVN7rocksdb9Benchmark10KeepFilterE[_ZTVN7rocksdb9Benchmark10KeepFilterE]+0x28): undefined reference to `rocksdb::Customizable::AreEquivalent(rocksdb::ConfigOptions const&, rocksdb::Configurable const*, std::__cxx11::basic_string*) const' /usr/bin/ld: CMakeFiles/db_bench.dir/tools/db_bench_tool.cc.o:(.data.rel.ro._ZTVN7rocksdb9Benchmark10KeepFilterE[_ZTVN7rocksdb9Benchmark10KeepFilterE]+0x38): undefined reference to `rocksdb::Configurable::PrepareOptions(rocksdb::ConfigOptions const&)' /usr/bin/ld:...

Thanks for looking into this and considering refactoring! RocksDB does not strictly require this, but it would be good engineering practice to have clear separation of private and public symbols...

@rhubner Any chance you might pick this up again some day? Having a clean ABI would be nice for stability and maintainability.

I rebased the patches in https://salsa.debian.org/debian/rocksdb/-/merge_requests/3 on latest 9.8.4 just to check if what happens, and I learned at the situation is still the same (same test build outcome, and...

Thanks @rhubner for looking into this. I applied the latest version of this on top of latest RocksDB version in Debian and build is failing due to undefined references. Build...

Note: Discussion about this continued in https://github.com/facebook/rocksdb/pull/12944 in August and November

Related issue on aliases and systemd service sysvinit enable/disable syncing: https://github.com/systemd/systemd/issues/15394

@holyfoot @ralfgebhardt Do you want to review/comment this?

The original PR #3502 and [MDEV-33834](https://jira.mariadb.org/browse/MDEV-33834) was filed in in April 2024. As the year is coming to an end, can you advice us on what we should do to...