Otto Kekäläinen
Otto Kekäläinen
Thanks for the review @LinuxJedi! > My intention was that these two aren't quite related. If you do not have TLS enabled, for whatever reason, this seems vulnerable to me....
The HTTP 302 redirect is not used in High Availability setups. Usually in HTTP you have multiple IP addresses for one single hostname and then multiple HTTP servers responding at...
I've updated https://salsa.debian.org/mariadb-team/mariadb-server/-/merge_requests/78 to have the latest version of this and I intend to work on this once we have all vector stuff done first.
This PR was discussed in https://jira.mariadb.org/browse/MDEV-28914 Latest comment by @vuvova > force_cpdir — right, I see. Perhaps, then, copy_files_wildcard should copy directories recursively then? In fact, I'd personally prefer to...
Please re-review updated version
@PhysicsTing Please rebase one more time and mark discussions as "resolved". I just clicked the button to request re-review from Andrew.
Thanks @dr-m for reviewing! Could you please clarify your feedback a bit and state what (if anything) you request to be changed or as next steps in general for this...
:+1: Unsurprisingly this PR looks good to me since it is upstreaming changes done in Debian in e.g. * https://salsa.debian.org/mariadb-team/mariadb-server/-/commit/a3b6f3d7f4b88074c76fe67d909977e74d8ba7a5 * https://salsa.debian.org/mariadb-team/mariadb-server/-/commit/b935704063506b1581b297a80cdfe00deda65640 * https://salsa.debian.org/mariadb-team/mariadb-server/-/commit/f2fe8d8300642c373ce325f19d1100d79adeed45 * https://salsa.debian.org/mariadb-team/mariadb-server/-/commit/92c1748770506c9364fe67b8a3fbc1221d71653b * https://salsa.debian.org/mariadb-team/mariadb-server/-/commit/9787b43c9601a3e1e497d22140de13122277d5c3 Hope to...
We know you @vuvova are busy, but perhaps you could do a superficial review to let us know if you agree with this change in principle?
This has been open for well over a month without any responsed - can you please review it @LinuxJedi? Thanks!