Johannes Otepka

Results 24 comments of Johannes Otepka

I'm getting closer to a fully working implementation. But before actually replacing shell code in ipyparallel/cluster/launcher.py I may ask for your feedback regarding the proposed implementation: I changed to name...

I have been working work hard to get the shellcmd functionality working on all platforms and shells. Only relying on the Github runners was way to ineffective (much slower compared...

Thanks very much for your quick reply. Ok, then I will definitely go for the piping method. I will clean up my code a bit and send a draft pull...

I havn't recieved any feedback on my PR yet. Is this because of viewers lack of time or because th PR is not fully working under Github Runners yet? or...

Thanks and I didn't want to stress you. Since I have no experince with PR I wasn't sure if I did all correctly. By the way, the pre-commit.ci run shows...

Thanks very much for the pre-commit explanations! Finally, I almost got the ssh tests with the Windows github runner to work - see my [last SSH-Test run](https://github.com/ottointhesky/ipyparallel/actions/runs/6656560041/job/18089380583). The last ‘big’...

Thanks again for the infos. By adding a corresponding entry to the container hosts file (of course the docker add host command does NOT support windows...), I was able to...

YEEESSS. Turning off the windows firewall was the final missing link. As you can see [here](https://github.com/ottointhesky/ipyparallel/actions/runs/6751067831), the ssh tests did work (persistence paid off eventually) As mentioned before, the SSHProxy...

Finally, everything is working and code, github workflows, etc. is cleaned up and (hopefully) properly comment. So from my side the PR is ready "to go..."

I do want to be annoying, but did you have time to look at the pull request? If you have any suggests for improvement/changes I'm happy to adapt the code....