forgottenserver icon indicating copy to clipboard operation
forgottenserver copied to clipboard

Live cast system [$205]

Open Znote opened this issue 11 years ago • 15 comments

Live Cast System

twifysoft.net has a very good cast system, but I understand if they wish to keep the sources closed. However, I believe a good live cast system will help the growth of this community, and motivate more people to jump on projects based on this repository.

So I want a live cast system, on this official repository.

How I want it to work (copied from twifysoft):

  • You can start casting by typing the command !cast ingame.
  • You can also start casting with a password, by using the command !cast password.
  • Login to the server without account name to watch a live cast.
  • If the cast has a password, enter the password in the password login field (still empty account name).
  • An in-game cast group chat channel. If the caster has the channel open, it is considered enabled, if caster is not in the channel its considered disabled.

Code quality guidelines:

@marksamman:

  • The use of the dispatcher thread must be minimal (viewers should receive a copy of the packets sent to the caster in asio thread).
  • All caster variables must be stored in (or in another object referenced from) the ProtocolGame instance of the caster player.

I will be the first here to take initiative and use Bountysource, I hope more people will follow. :+1:

There is a $205 open bounty on this issue. Add to the bounty at Bountysource.

Znote avatar Sep 10 '14 19:09 Znote

Nice :+1:

Nu77 avatar Sep 11 '14 06:09 Nu77

yep I make my contribution

mattyx14 avatar Sep 11 '14 14:09 mattyx14

great :+1: this will for sure bump the usage of tfs 1.0

ghost avatar Sep 13 '14 01:09 ghost

If I publish my system, I get how much?

rodrigoslayertech avatar Feb 21 '15 02:02 rodrigoslayertech

if it fulfills all @marksamman requirements you may get the bounty I guess

ghost avatar Feb 21 '15 02:02 ghost

@marksamman @djarek Not sure whats going on with the bountysource integration, but I chipped in some extra bucks raising this from $170 to $205.

Znote avatar Apr 20 '16 06:04 Znote

@Znote it's working. There is a $205 open bounty on this issue. Add to the bounty at Bountysource.

ranisalt avatar Apr 20 '16 06:04 ranisalt

Isn't @djarek system already done and working? Most of the people that shows up with errors are using it with modifications

gugahoa avatar Apr 20 '16 08:04 gugahoa

@ranisalt I edited that myself manually, the title still says $170 and it appears I cannot change that.

@gugahoa There is a pull request by djarek, but it hasn't been accepted and merged yet by Marksamman. Last thing I read there are some dodgy code in the shadows of this request that need some work for the sake of this request, as well as some good testers who know how to use a debugger. (But don't take my word for this).

I don't care if a pull request is working, it has to be merged to master or the bounty still stands.

Znote avatar Apr 20 '16 10:04 Znote

There seems to be an issue with the Bountysource integration. I've tried re-enabling it without any success, until we figure it out, people interested in bounties should check the Bountysource page for the project for accurate information on bounties. As for the pull request, I'm still waiting to hear from people how well it works without additional modifications to the source code. I don't have a server with enough activity to test it myself.

marksamman avatar Apr 20 '16 12:04 marksamman

Djarek and Milice cast not work on tfs 1.2 final release problem on compilling ^^ i see this system its rlly hard to be work good 🗡 ; D `Error LIST

Severity Code Description Project File Line Suppression State Warning C4100 'accountId': unreferenced formal parameter theforgottenserver C:\Users\D\Desktop\Milice\forgottenserver-1.2\src\protocolspectator.cpp 61 Warning C4100 'forced': unreferenced formal parameter theforgottenserver C:\Users\D\Desktop\Milice\forgottenserver-1.2\src\protocolspectator.cpp 158 Warning C4100 'displayEffect': unreferenced formal parameter theforgottenserver C:\Users\D\Desktop\Milice\forgottenserver-1.2\src\protocolspectator.cpp 158 Warning C4100 'broadcast': unreferenced formal parameter theforgottenserver C:\Users\D\Desktop\Milice\forgottenserver-1.2\src\protocolspectator.cpp 296 Error C2039 'getLevelPercent': is not a member of 'Player' theforgottenserver C:\Users\D\Desktop\Milice\forgottenserver-1.2\src\protocolspectator.cpp 2752 Error C2039 'getMagicLevelPercent': is not a member of 'Player' theforgottenserver C:\Users\D\Desktop\Milice\forgottenserver-1.2\src\protocolspectator.cpp 2765

Output

1>..\src\protocolspectator.cpp(61): warning C4100: 'accountId': unreferenced formal parameter 1>..\src\protocolspectator.cpp(158): warning C4100: 'forced': unreferenced formal parameter 1>..\src\protocolspectator.cpp(158): warning C4100: 'displayEffect': unreferenced formal parameter 1>..\src\protocolspectator.cpp(296): warning C4100: 'broadcast': unreferenced formal parameter 1>..\src\protocolspectator.cpp(2752): error C2039: 'getLevelPercent': is not a member of 'Player' 1> c:\users\d\desktop\milice\forgottenserver-1.2\src\npc.h(29): note: see declaration of 'Player' 1>..\src\protocolspectator.cpp(2765): error C2039: 'getMagicLevelPercent': is not a member of 'Player' 1> c:\users\d\desktop\milice\forgottenserver-1.2\src\npc.h(29): note: see declaration of 'Player'

Protocolspectator.cpp Line 61 - void ProtocolSpectator::login(const std::string& name, uint32_t accountId, OperatingSystem_t operatingSystem) Line 158 - void ProtocolSpectator::logout(bool displayEffect, bool forced) Line 296 - void ProtocolSpectator::writeToOutputBuffer(const NetworkMessage& msg, bool broadcast/* = false*/) { Line 2752 - msg.addByte(player->getLevelPercent()); Line 2765 - msg.addByte(player->getMagicLevelPercent());

Any Solution for this ? `

DamianDEB avatar Dec 01 '16 12:12 DamianDEB

@djarek https://github.com/otland/forgottenserver/pull/994#issuecomment-263083940

I'll resubmit a new pull request when I rebase. This PR has way too many spam messages.

Could you give a status on this?

Znote avatar Feb 18 '17 13:02 Znote

@Znote I want to merge #2010 before the casting system so that the latter uses the API rather than push redundant stuff into the database.

djarek avatar Feb 20 '17 21:02 djarek

@Znote I will start working on this very soon!

@djarek If you have already started this, inform me and I am stopping at once!

slavidodo avatar Apr 08 '17 22:04 slavidodo

I'm going to start working on it.

miezaF avatar Oct 16 '19 18:10 miezaF