forgottenserver icon indicating copy to clipboard operation
forgottenserver copied to clipboard

Change lua_pushnumber to lua_pushinteger for non floating point values

Open xmish opened this issue 1 year ago • 4 comments

Pull Request Prelude

Changes Proposed

Replace some lua_pushnumber with lua_pushinteger to fix display of some integer values in game. I'm not sure if it's a valid approach and also I'm not sure about changes in:

  • setField
  • LuaScriptInterface::registerVariable

Issues addressed: #4522

xmish avatar Sep 01 '23 23:09 xmish

Sorry missclicked

ranisalt avatar Sep 02 '23 23:09 ranisalt

needs a rebase

EvilHero90 avatar Jun 02 '24 00:06 EvilHero90

@EvilHero90 we can't merge this right now because it implies dropping LuaJIT support, but we can do it for the next release cycle

ranisalt avatar Jun 02 '24 20:06 ranisalt

@EvilHero90 we can't merge this right now because it implies dropping LuaJIT support, but we can do it for the next release cycle

There was no intention to push this immediatly, I just want to see if this gets worked on or not

EvilHero90 avatar Jun 02 '24 20:06 EvilHero90