forgottenserver icon indicating copy to clipboard operation
forgottenserver copied to clipboard

actions: build .deb & fixes

Open DSpeichert opened this issue 2 years ago • 3 comments

Pull Request Prelude

Changes Proposed

Issues addressed:

  • Ubuntu builds were not properly uploading binary to artifacts
  • a .deb package is now uploaded too
  • test workflow does not run unnecessarily

DSpeichert avatar Aug 05 '23 18:08 DSpeichert

I doubt enough people use raw TFS without changes to warrant maintaining this.

ranisalt avatar Aug 07 '23 16:08 ranisalt

I doubt enough people use raw TFS without changes to warrant maintaining this.

It's mostly easy of use for those who are sticking to a tagged branch, especially if I figure out a way to maintain an APT repo. Doesn't cost us anything to keep it here.

DSpeichert avatar Aug 07 '23 22:08 DSpeichert

People can always use Docker for that, which is way easier, and works in every distro.

Doesn't cost us anything to keep it here.

I can see it does just by looking at the package list and seeing different packages from that Ubuntu and vcpkg install. It's a third list of dependencies (not counting the ones on the wiki) that we need to keep updated and that we will not keep updated

ranisalt avatar Aug 09 '23 08:08 ranisalt