forgottenserver icon indicating copy to clipboard operation
forgottenserver copied to clipboard

Improvement suggestion in the playerdeath table

Open luanluciano93 opened this issue 1 year ago • 1 comments

Before creating an issue, please ensure:

  • [x] This is a bug in the software that resides in this repository, and not a support matter (use https://otland.net/forums/support.16/ for support)
  • [x] This issue is reproducible without changes to the C++ code in this repository

Expected behaviour

Columns "killed_by" and "mostdamage_by" cannot carry the player ID? I had problems when I used a "change name", the table stored the old names.

https://github.com/otland/forgottenserver/blob/master/schema.sql#L271-L284

luanluciano93 avatar Apr 28 '23 02:04 luanluciano93

I know its better to have as default, but here is the necessary modification.

local function getKiller(killer)
	if not killer then
		return false, "field item"
	end

	if killer:isPlayer() then
		return true, killer:getGuid()
	end

	local master = killer:getMaster()
	if master and master ~= killer and master:isPlayer() then
		return true, master:getGuid()
	end

	return false, killer:getName()
end

now you need to change your acc to get player by id too

mano368 avatar Jun 26 '23 18:06 mano368