forgottenserver icon indicating copy to clipboard operation
forgottenserver copied to clipboard

notify the client about NPC speechbubble update

Open Zbizu opened this issue 2 years ago • 4 comments

Pull Request Prelude

Changes Proposed

send the new speech bubble to the players who see the npc in their game screen

Issues addressed: more improvements to #4009 (merged PR)

Zbizu avatar Apr 02 '22 04:04 Zbizu

Move it to separate method in game class for example updateCreature(Creature*)?

nekiro avatar Apr 02 '22 08:04 nekiro

Move it to separate method in game class for example updateCreature(Creature*)?

I like it, we can use in

luascript.cpp > luaCreatureSetMaster()
monster.cpp > setName()

ramon-bernardo avatar Apr 02 '22 11:04 ramon-bernardo

The loop occurs in three different places in the code. I will just make a function as Nekiro suggested.

Zbizu avatar Apr 02 '22 16:04 Zbizu

nvm, I don't have time to finish it I'll keep it open in case someone wants to finish it.

Zbizu avatar Apr 30 '22 17:04 Zbizu