copy icon indicating copy to clipboard operation
copy copied to clipboard

[WIP] Skip device files by default: Use opt.Specials

Open otiai10 opened this issue 1 year ago • 2 comments

Fix #78

otiai10 avatar Jul 20 '22 04:07 otiai10

will fix https://github.com/GoogleContainerTools/kaniko/issues/960

otiai10 avatar Jul 20 '22 04:07 otiai10

Codecov Report

Merging #84 (ae3e4ab) into main (8575144) will increase coverage by 0.25%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #84      +/-   ##
==========================================
+ Coverage   77.40%   77.65%   +0.25%     
==========================================
  Files          13       13              
  Lines         177      179       +2     
==========================================
+ Hits          137      139       +2     
  Misses         20       20              
  Partials       20       20              
Impacted Files Coverage Δ
options.go 85.71% <ø> (ø)
copy.go 76.00% <100.00%> (+0.48%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8575144...ae3e4ab. Read the comment docs.

codecov-commenter avatar Jul 20 '22 04:07 codecov-commenter

I'm hitting the aforementioned kaniko issue. Is anything blocking this? Is testing needed?

ajakk avatar Nov 07 '22 17:11 ajakk

this is ready. thx

otiai10 avatar Nov 09 '22 01:11 otiai10

Thank you!

ajakk avatar Nov 09 '22 01:11 ajakk