cls-middleware

cls-middleware copied to clipboard

continuation-local-storage should be a peer dependency, not a dependency

1

let the project determine the version, as long as it befits your dependency policy. AFAIK - the way to do that is using `peerDependencies`, and not `dependencies`. Classical case IMHO

osher

Readme has incorrect spelling of Namespace

1

samjeffress

`res.send({value : cls.getNamespace('namespace').get('whatever')});` had NameSpace (capital s) which makes copy paste fail :)

samjeffress

tests failing

1

2 of the 7 tests are failing. Tested using node 5.7.0 & node 6.3.1 Here's the output ``` draco:cls-middleware detj$ npm test > [email protected] test /Users/detj/tmp/cls-middleware > tap test/*.tap.js not...

detj

req and res should be bound inside the new context

1

The existing code binds `req` and `res` before starting a new context: ``` javascript module.exports = function clsify(ns) { if (!ns) throw new Error('CLS namespace required'); return function (req, res,...

coltrane

antonmos

The most important fix was getNameSpace => getNamespace but also the removal of the superfluous "next()" in the route (necessary for restify but makes express crash with "Error: Can't set...

gabrielf