takuya kodama

Results 124 comments of takuya kodama

@akr Sorry to bother you while you're busy. If there is any missing information or unclear parts that would help in reviewing this PR, please let me know. I’m more...

@akr Thank you for explaining the proposed method to customize header fields for each request using a hash or a block. I think the policy to allow customizable headers is...

Thank you for clarifying the specification. I also understand your decision not to introduce the default behavior for the `Authorization` header. With that in mind, I will proceed to implement...

@akr Thank you for your guidance on the header customization using a Hash and a Proc object. I have implemented the `request_specific_fields` option. Could you please review the implementation to...

@redboltz Of course, I will check it as much as I can. I couldn't try it but I think we cannot use relative paths for `CMAKE_INSTALL_LIBDIR` and `CMAKE_INSTALL_INCLUDEDIR` using `pkg-config`....

> Can we integrate https://github.com/jtojnar/cmake-snips/blob/master/CMakeScripts/JoinPaths.cmake into this build? (It is MIT-licensed)? I believe I have already done so in the following section: https://github.com/msgpack/msgpack-c/blob/a5c8a2c845ba43100b7cad7f8a8db0c2ce361d1e/CMakeLists.txt#L33-L42 However, I think the issue lies in...

I tried to fix the above problem at this PR https://github.com/msgpack/msgpack-c/pull/1125. Could you give me the advice if I miss something? šŸ™šŸ¾

Yes it is. I will add it to the description.

## Build with UBSAN using GCC ```bash rm -rf ../groonga.ubsan && \ cmake \ -S . \ -B ../groonga.ubsan \ --preset=debug-default \ -DCMAKE_INSTALL_PREFIX=/tmp/local \ -DCMAKE_C_FLAGS="-fsanitize=undefined" \ -DCMAKE_CXX_FLAGS="-fsanitize=undefined" &&\ cmake --build...

In MariaDB, they use the following options for UBSAN. Will `no-sanitize=alignment` option suppress the `requires 8 byte alignment` errors? https://github.com/MariaDB/server/blob/22efc2c784e1b7199fb5804e6330168277ea7dce/CMakeLists.txt#L237-L240