GRIP icon indicating copy to clipboard operation
GRIP copied to clipboard

Wrist index in data processing-'add wrist perturbation' part

Open Zhengyu-Li opened this issue 1 year ago • 0 comments

Thanks for the great work. I have some questions about the codes.

  1. In data processing part, I found you add some perturbation to joint #18(right elbow) and #19(left wrist) https://github.com/otaheri/GRIP/blob/64b160e34f52f8bb08f1955d332155ffcd37cfbd/data/process_data.py#L336 But according to the paper and code comments, here should be left and right elbow. Same problem for adding shoulder perturbation in next few lines. I follow the index in Grab code here https://github.com/otaheri/GRAB/blob/284cba757bd10364fd38eb883c33d4490c4d98f5/tools/utils.py#L166
  2. From my understanding of your code, the sbj_output_p is for RNet training and sbj_output_p_arms is for ANet(if wrong please correct me...). But here you send sbj_output_p_arms params to sbj_output_p. Is this a typo?https://github.com/otaheri/GRIP/blob/64b160e34f52f8bb08f1955d332155ffcd37cfbd/data/process_data.py#L356

Looking forward to your reply. Thank you.

Zhengyu-Li avatar Jul 14 '24 09:07 Zhengyu-Li