Oliver Tacke

Results 47 issues of Oliver Tacke

The `unload` event is deprecated (https://developer.mozilla.org/en-US/docs/Web/API/Window/unload_event). https://github.com/h5p/h5p-editor-php-library/blob/8cd9c7fb9a3668fa553b0e093078e87a1fbcdc6d/scripts/h5peditor-editor.js#L92

When merged in, will fix using a default value set in semantics. According to https://h5p.org/semantics#attribute-default the library widget should be able to accept a default value. That doesn't work currently,...

When merged in, lists will use their `removeItem` function inside `removeAllItems`. Keeps the code DRY and also triggers `removedItem` events that other components may need.

When merged in, will remove the list editor's item element ($item) not only when removing the item via the GUI, but when programmatically removing the underlying list item. Currently, the...

When merged in, will improve the specificity of `.h5p-image-hotspot-question` to avoid collision with H5P.ImageHotspotQuestion.

When merged in, will fix the detection of allowed file types. Currently, `mimeType` is set as an object key, not the value of the variable named `mimeType`.

In https://github.com/h5p/h5p-cli/blob/b2667b3b044a048c11aa933685beca4605439dac/assets/utils/h5p.js#L1021-L1023 default fields that contain one of the language codes only will be purged. This is too greedy and also hits the simple English word "No" that happens to...