eslint-plugin-json-schema-validator icon indicating copy to clipboard operation
eslint-plugin-json-schema-validator copied to clipboard

Timeout of 10000ms exceeded for get-modules/http.js

Open adamlui opened this issue 9 months ago • 1 comments

This used to happen once in a while, but now it is so frequent, I have to retry 3-4 times to make it go away

image

from https://github.com/kudoai/bravegpt

adamlui avatar Apr 26 '24 17:04 adamlui

Pull requests are welcome, I think it should be made optional.

ota-meshi avatar Apr 27 '24 00:04 ota-meshi

I have changed the timeout to 60s. If you are still having problems, please open a new issue.

ota-meshi avatar Jun 21 '24 01:06 ota-meshi

I think that will just make it worse. Previously after 10s timeout, terminal just hangs around in limbo state, then sometimes ESLint finishes successfully, other times fails (after an even longer wait).

Now, it will take a whole minute to timeout before proceeding to slowly succeed/fail...

adamlui avatar Jun 21 '24 01:06 adamlui

You should just spy on how your biggest competitor bypasses having to rely on this unreliable module (i used them prior but switched since this also covered yaml, but if issue persists i'ma just switch back)

adamlui avatar Jun 21 '24 01:06 adamlui

I'm not sure what you want to change. Could you open a new issue and explain in more detail?

ota-meshi avatar Jun 21 '24 02:06 ota-meshi

But it's not a separate issue. get-modules/http.js makes your plugin unusable. I want to change using your plugin for your competitor's because no such issues exist in his working version

adamlui avatar Jun 21 '24 02:06 adamlui

I didn't change yet because I have like 30+ repos that use ESLint

adamlui avatar Jun 21 '24 02:06 adamlui

What I'm saying is your plugin does not work because of get-modules/http.js regardless of timeout duration, so you must replace this dependency or others will leave too

adamlui avatar Jun 21 '24 02:06 adamlui

This error occurs 100% of the time now

adamlui avatar Jun 21 '24 02:06 adamlui

What I'm saying is your plugin does not work because of get-modules/http.js regardless of timeout duration, so you must replace this dependency or others will leave too

Still not sure. What is your suggestion?

ota-meshi avatar Jun 21 '24 02:06 ota-meshi

I said it 2 times don't use get-modules/http.js spy on the other json plugin see how they don't rely on it, just copy same thing

adamlui avatar Jun 21 '24 02:06 adamlui

Wait ignore me increased timeout worked

adamlui avatar Jun 21 '24 02:06 adamlui

How would we make this plugin work if we didn't use get-modules/http.js?

ota-meshi avatar Jun 21 '24 02:06 ota-meshi

However the other plugin makes it work without this sporadic issue

adamlui avatar Jun 21 '24 02:06 adamlui

If he's using same dependency then the implementation is just flawed

adamlui avatar Jun 21 '24 02:06 adamlui

However the other plugin makes it work without this sporadic issue

I didn't know there was another ESLint plugin that has the same functionality as this one, and if it works well, it would make sense to use it. Could you please tell me which plugin it is, if possible?

ota-meshi avatar Jun 21 '24 02:06 ota-meshi

I'm busy but you can easily find it on search engine by typing something like ESLint JSON plugin

adamlui avatar Jun 21 '24 02:06 adamlui

Okay. I'll lock this thread then.

ota-meshi avatar Jun 21 '24 02:06 ota-meshi