osu-droid icon indicating copy to clipboard operation
osu-droid copied to clipboard

enable workflow_dispatch and attach debug APK for Android CI

Open 0komo opened this issue 1 year ago • 9 comments

Closes #335

Changes to Android CI (android.yml):

  • Enable workflow_dispatch
  • Attach debug APK and SHA256 checksum file

0komo avatar Mar 17 '24 11:03 0komo

Is there a reason for running the workflow on every push?

Rian8337 avatar Mar 18 '24 05:03 Rian8337

Is there a reason for running the workflow on every push?

It's already there since I made the workflow to attach artifacts, perhaps I need to restrict on certain path?

0komo avatar Mar 18 '24 17:03 0komo

Apologies, I meant to ask about the artifact part.

Rian8337 avatar Mar 18 '24 22:03 Rian8337

If you meant why is it need to be attach with APK artifact, see the issue I referenced.

0komo avatar Mar 19 '24 00:03 0komo

I understand why, but I don't understand why the APK artifact must be attached on every push or pull request.

Rian8337 avatar Mar 19 '24 01:03 Rian8337

There's no reason to it, other than being faster way to build the APK and test it right in your phone whether. I can restrict it to only attach when pushing/making PR on specific path, or restrict it at all and only attach if it's triggered by workflow_dispatch event.

0komo avatar Mar 24 '24 19:03 0komo

or restrict it at all and only attach if it's triggered by workflow_dispatch event.

I think that would suffice. There may be cases where a commit should not be tested publicly (i.e., incomplete implementation of a feature), so it should be opt-in.

Rian8337 avatar Mar 28 '24 04:03 Rian8337

Then disabling it via commit message could work, such as noci or skipci at the end of commit message.

0komo avatar Mar 28 '24 17:03 0komo

so it should be opt-in.

Rian8337 avatar Mar 28 '24 21:03 Rian8337