bancho.py icon indicating copy to clipboard operation
bancho.py copied to clipboard

Published 20 hours ago • verified publisher icon osuAkatsuki

refactor: implement repositories

Open 7mochi opened this issue 1 year ago • 4 comments

  • [x] Logs #484
  • [x] Map requests #485
  • [x] Comments #486
  • [x] Mails #487
  • [x] Ingame logins #489
  • [x] Client hashes #595
  • [x] Favourites #598
  • [x] Map ratings #599
  • [ ] User achievements
  • [x] Tourney pools #597
  • [x] Tourney pool maps #597
  • [ ] Players
  • [ ] Channels
  • [ ] Clans
  • [ ] Matches
  • [ ] API keys
  • [ ] User Relationships

7mochi avatar Sep 21 '23 13:09 7mochi

What is the direction you are going with the repository PRs? I see you changed the branch for them

NiceAesth avatar Sep 21 '23 13:09 NiceAesth

What is the direction you are going with the repository PRs? I see you changed the branch for them

~~I wanted to make another PR with all the repositories implemented~~ nvm

7mochi avatar Sep 21 '23 13:09 7mochi

I've created this PR as a reference for breaking up the collections modules, as they may be a bit trickier than usual:

  • https://github.com/osuAkatsuki/bancho.py/pull/597

This PR's description breaks down how we might approach players, channels, clans and matches similarly.

cmyui avatar Feb 15 '24 06:02 cmyui

just adding a note onto this about us refactoring existing repositories to sqlalchemy core (for query building), any further repos should be made in the same manor (use #632 as a good example of pretty much any usecase you might run into when writing the repos)

tsunyoku avatar Feb 20 '24 11:02 tsunyoku