bancho.py
bancho.py copied to clipboard
osuAkatsuki
Critical PP calculation bug in osu!mania
When user is trying to submit a score in osu!mania, with ScoreV2 + NoFail. PP calculation gets literal autism and does stuff like that:
I'd like to say that max pp on for example Triumph and regret is around 680 (With DT).
Currently I just disabled score submission for this mods combination in mania but I guess there's a better way to solve this :^)
this issue is probably better targetted towards the pp system repo and not us because it's not our issue
this issue is probably better targetted towards the pp system repo and not us because it's not our issue
I found why and it's actually gulag's bug
Mania without V2 has score multiplier for NoFail, (0.5x). V2 has no score multiplier for V2. Score with V2NF gets passed to pp calculation as higher than maximum. For example let's take 950k score, pp system sees that it's with NF so it expects 500k score at most, 950k is obviously higher than maximum, it's like giving 10m score on some harumachi clover where max score is for example 300k, system will go crazy.
Good solution would be just applying score multipliers even in ScoreV2
still suited to the pp system repo - the pp system should be responsible for scaling the score and not us, we just provide the score details :O
Before switching the code of bancho.py to rosu-pp-py, you can fix this by pip install peace-performance-python==2.0, which uses the latest code from rosu-pp.
I'm not sure if this problem exists with rosu-pp, you can try it
we already use rosu-pp!
Currently this repository still uses peace-performance-python=1.1.2 [requirements.txt](https://github.com/osuAkatsuki/bancho.py/blob/master/requirements.txt) and some users reported the same issue to me.
So a temporary solution is necessary
hm i thought we switched to rosu-pp :o in that case i’ll likely just switch over to rosu-pp
hm i thought we switched to rosu-pp :o in that case i’ll likely just switch over to rosu-pp
Yes, sorry, I haven't followed any of these in a while, and switching to rosu-pp is a better option.