vsts-contributions icon indicating copy to clipboard operation
vsts-contributions copied to clipboard

PR review activity is counted towards the day PR was closed.

Open Volkmire opened this issue 4 years ago • 0 comments

Describe the bug PR review activity is counted towards the day PR was closed.

Environment:

  • Azure DevOps Server 2019

To Reproduce

  1. Review PR and vote for it on day 1.
  2. Close PR on day 2.
  3. Check the date PR review is attributed to (day 2 will be counted towards contribution even if someone else closes PR).

Expected behavior

  1. Review request and vote for it on day 1.
  2. Close PR on day 2
  3. Check the date PR review is attributed to (should be day 1).

Additional context It should be noted that one person might review the same PR multiple times. Example scenario:

  • Please review me.
  • Your code is shit, start all over.
  • Please review me again. I suggest every vote should be counted. It is an open question if one should count multiple votes on the same PR during the day.

Volkmire avatar Feb 02 '21 15:02 Volkmire