ostelco-core icon indicating copy to clipboard operation
ostelco-core copied to clipboard

Feature/retry logic in es2plus client

Open la3lma opened this issue 4 years ago • 3 comments

Feature to fix bug/misfeature: Some times the ES2+ responds slowly, and this patch gives the client a little more time to get it right before signalling a failure.

Also some refactoring/additional documentation (based on hints from Intellij which checks for such things before committing to VCS).

la3lma avatar Nov 26 '19 12:11 la3lma

What is the timeout for requests set to in the HttpClient?

mpeterss avatar Nov 26 '19 13:11 mpeterss

Timeout is set to ten seconds: httpClient: timeout: 10000ms

la3lma avatar Nov 26 '19 13:11 la3lma

Have submitted a new one-line PR with the change suggested by @vihangpatil. If that does the trick, I will rework this PR into a pure refactoring PR (adding documentation etc.), and remove the retry logic.

la3lma avatar Nov 28 '19 19:11 la3lma