Add adv currency formatting

Open Draal opened this issue 1 month ago • 1 comments

Checklist

[ ] I have read the contribution guidelines.
[ ] make test passes.
[ ] make lint passes.
[ ] New and changed code is covered by tests.
[ ] Performance improvements include benchmarks.
[ ] Changes match the documented (not just the implemented) behavior of Shopify.

Nov 13 '25 06:11 Draal

Thank you for your interest in contributing to this project!

However, I'm unable to merge this PR as it appears to be a fork divergence rather than a focused contribution. Here are the main concerns:

Fork-specific changes: This PR changes all repository URLs from osteele/liquid to autopilot3/liquid across 64 files. These URL changes would break all links in the documentation and point users to a different repository.
Out of scope: This project's goal is compatibility with Shopify Liquid. The PR adds many custom filters and features that are not part of Shopify Liquid:
- Custom cryptographic filters (md5, sha1, sha256, hmac variants)
- Proprietary phone number formatting filters
- CRM-specific functionality (activity IDs, display types, custom tags)
- Custom set operations (setContains, setContainsAll)
These belong in application code as extensions (see osteele/gojekyll for an example), or in a fork, not in this library.
Massive scope: With 2,522 additions across 64 files and 90+ commits, this mixes too many unrelated changes to review effectively.
Incomplete submission: The checklist in the PR description is empty, and many commits reference "WIP" or linting fixes.

Contributions that would be welcome:

Custom filters should be added by users of the library, not included in the core library.

I recommend closing this PR. If you need these custom features, please maintain them in your fork (autopilot3/liquid).

Nov 15 '25 02:11 osteele