rocket-webapp-components icon indicating copy to clipboard operation
rocket-webapp-components copied to clipboard

Is not recommended to overwrite font and style in theme files

Open alexandra-c opened this issue 4 years ago • 1 comments

We should not overwrite styles. There is a defaultFont object that should be used in all the components we want to. In this way we will keep the Font and Style information in one place. https://github.com/osstotalsoft/rocket-webapp-components/blob/5106659b4e3e439c3f82ad34d106cbf22e8fb4e0/themes/vividOrangeTheme.js#L181-L188

The above code should be removed, especially the !Important attribute and fix the issue. If you needed to use !Important it means that someone is overriding these theme configs and in this case you must figure out where that happens and make sure it uses the defaultFont object instead.

alexandra-c avatar Jan 11 '21 09:01 alexandra-c

@alexandra-c ma poti ajuta cu asta?

VCuzmin avatar Mar 18 '21 14:03 VCuzmin