srs icon indicating copy to clipboard operation
srs copied to clipboard

For #2952: Support CircleQueue for multiple threads.

Open fairywh opened this issue 3 years ago • 2 comments

Summary

用于多线程之间的消息队列。

Details

1)无CAS无Mutex同步 2)支持单写单读

Benchmark:https://github.com/ossrs/srs/issues/2952

fairywh avatar Mar 11 '22 11:03 fairywh

Thank you for submitting the PR 👍 Make sure to maintain the markdown structure.

TRANS_BY_GPT3

winlinvip avatar Mar 12 '22 10:03 winlinvip

Codecov Report

Merging #2965 (b83c1a8) into develop (d117145) will decrease coverage by 0.16%. The diff coverage is 30.42%.

@@             Coverage Diff             @@
##           develop    #2965      +/-   ##
===========================================
- Coverage    56.80%   56.63%   -0.17%     
===========================================
  Files          149      150       +1     
  Lines        57907    58084     +177     
===========================================
+ Hits         32896    32898       +2     
- Misses       25011    25186     +175     

| Impacted Files | Coverage Δ | |'

Translated to English while maintaining the markdown structure:

'| Impacted Files | Coverage Δ | | |---|---|---| | trunk/src/app/srs_app_config.cpp | 64.49% <0.00%> (-0.44%) | :arrow_down: | | trunk/src/app/srs_app_config.hpp | 100.00% <ø> (ø) | | | trunk/src/app/srs_app_dvr.cpp | 0.00% <ø> (ø) | |'

Translated to English while maintaining the markdown structure:

'| trunk/src/app/srs_app_config.hpp | 100.00% <ø> (ø) | | | trunk/src/app/srs_app_dvr.cpp | 0.00% <ø> (ø) | | | trunk/src/app/srs_app_hybrid.cpp | 12.72% <0.00%> (-0.24%) | :arrow_down: | | trunk/src/app/srs_app_reload.cpp | 2.85% <ø> (+0.35%) | :arrow_up: | | trunk/src/app/srs_app_server.cpp | 0.00% <0.00%> (ø) | | | trunk/src/main/srs_main_server.cpp | 0.00% <0.00%> (ø) | | | trunk/src/protocol/srs_protocol_log.cpp | 84.12% <ø> (ø) | | | trunk/src/utest/srs_utest_reload.cpp | 92.37% <ø> (-2.16%) | :arrow_down: |

Translated to English while maintaining the markdown structure:

| trunk/src/app/srs_app_reload.cpp | 2.85% <ø> (+0.35%) | :arrow_up: | | trunk/src/app/srs_app_server.cpp | 0.00% <0.00%> (ø) | | | trunk/src/main/srs_main_server.cpp | 0.00% <0.00%> (ø) | | | trunk/src/protocol/srs_protocol_log.cpp | 84.12% <ø> (ø) | | | trunk/src/utest/srs_utest_reload.cpp | 92.37% <ø> (-2.16%) | :arrow_down: | | trunk/src/app/srs_app_log.cpp | 13.95% <3.57%> (-1.05%) | :arrow_down: | | ... and 8 more | |


Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data'

Translated to English while maintaining the markdown structure:

Δ = absolute <relative> (impact), ø = not affected, ? = missing data' Powered by Codecov. Last update d117145...b83c1a8. Read the comment docs.

TRANS_BY_GPT3

codecov-commenter avatar Mar 13 '22 02:03 codecov-commenter

There is still some issues need to be fixed in cygwin, and CAS seems not improved a lot, so it's better to use general mutex(lock) if wants to create a queue.

Thanks for your PR 👍

winlinvip avatar Dec 06 '22 05:12 winlinvip