srs icon indicating copy to clipboard operation
srs copied to clipboard

Add the stream id attribute to the http on_publish callback

Open winlinvip opened this issue 3 years ago • 2 comments

For https://github.com/ossrs/srs/pull/2844

winlinvip avatar Jan 09 '22 05:01 winlinvip

Codecov Report

Merging #2859 (2213fb2) into 4.0release (08910e5) will decrease coverage by 0.01%. The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff               @@
##           4.0release    #2859      +/-   ##
==============================================
- Coverage       60.22%   60.20%   -0.02%     
==============================================
  Files             121      121              
  Lines           51070    51083      +13     
==============================================
  Hits            30756    30756              
- Misses          20314    20327      +13     

| Impacted Files | Coverage Δ | |'

Translated to English while maintaining the markdown structure:

'| Impacted Files | Coverage Δ | | |---|---|---| | trunk/src/app/srs_app_http_hooks.cpp | 0.00% <0.00%> (ø) | | | trunk/src/app/srs_app_rtc_api.cpp | 0.00% <0.00%> (ø) | | | trunk/src/app/srs_app_rtmp_conn.cpp | 0.00% <0.00%> (ø) | |'

Translated to English while maintaining the markdown structure:

'| trunk/src/app/srs_app_http_hooks.cpp | 0.00% <0.00%> (ø) | | | trunk/src/app/srs_app_rtc_api.cpp | 0.00% <0.00%> (ø) | | | trunk/src/app/srs_app_rtmp_conn.cpp | 0.00% <0.00%> (ø) | | | trunk/src/app/srs_app_statistic.cpp | 27.13% <0.00%> (-0.43%) | :arrow_down: |


Continue to review full report at Codecov.

Legend - Click here to learn more | Δ = absolute <relative> (impact), ø = not affected, ? = missing data |'

Translated to English while maintaining the markdown structure:

'| Δ = absolute <relative> (impact), ø = not affected, ? = missing data |

Powered by Codecov. Last update 08910e5...2213fb2. Read the comment docs.

TRANS_BY_GPT3

codecov-commenter avatar Jan 09 '22 05:01 codecov-commenter

Added a flag, adjusted the timing of http hook and stat, all just for one streamid, it doesn't seem worth it.

TRANS_BY_GPT3

duiniuluantanqin avatar Feb 04 '22 10:02 duiniuluantanqin

Fixed by 6a108fab6dddf5c4e0c61a88131f1ebc0ec89c30

winlinvip avatar Sep 01 '22 12:09 winlinvip