score icon indicating copy to clipboard operation
score copied to clipboard

Range editing for non-numeric and non-boolean types

Open reno- opened this issue 9 years ago • 7 comments

Create a parameter with type 'string' in a Minuit Device. in its device's explorer, i-score says that the min and max values are both 1025.

We might have a list of possible values defined in the parameter with the range attribute.

But I know that a revamp of min-max into domain needs to be done… so this issue is just here for the record

reno- avatar Dec 06 '15 16:12 reno-

I can confirm this trouble is not API related. if you have for example a [j.parameter options @type string @range "true false" "aez zre" "foo bar"] the Address is correctly created with a Domain.values = {"true false", "aez are", "foo bar"}.

theod avatar Dec 08 '15 15:12 theod

here is a simple test patcher to reproduce the problem :


----------begin_max5_patcher----------
384.3ocoRsraBCCD7bxWwJelRIPoP5INz+hRUkIrkZTv1xYCkGh+8tdMgRkJ
Gpphhs2w6yY7w7L0B2NrQAOAu.YYGyyxDnHP1Y6L0F8tpZci3lxhe5VrV0Kc
Eg6HAdceuNn2fDF.mmLNaCLi16QngBF6JXVPaWgvbEEZQ3cccCNWwlZ7.bHj
N+tyAKzg4ptzWarXkq0J0X3YPa6FisFIoeJNC50T0GbcdKfUTZdJJG0ePOn7
w35vBYaz39CfW+NQtVpKScoug1WixL00EImhCSJw7E7+kzXVJdyrxcCUQnS4
4wkd+WFkGyVC81RbqoBgY0tJc88VljANjm+Ap2EHnrrbZGfwCECmze.+UvbO
twQXJVycMUt.dATBsXz3IkWf9Yv5JxrEA9jmUR12eUcl9WUGQbJFKqOLU1hZ
zMTmA2Tcth9Ktl9kDozd+VLzvuGEEHx+L6u1EhlS5IlFaxT5VUfI1N+kppzA
t4ItyaCoRua5ipTntkXfEII57XkOk+EqAns7
-----------end_max5_patcher-----------

theod avatar Dec 08 '15 15:12 theod

I assign to @nvuaille but maybe it is for @jcelerier ?

theod avatar Dec 08 '15 15:12 theod

One of the problem here is that we display domain in the devices explorer with two columns : Min and Max. So maybe we need to display it with a unique column named domain.

reno- avatar Dec 08 '15 15:12 reno-

I fixed the 1025 being displayed part

jcelerier avatar Dec 19 '15 13:12 jcelerier

This should be considered when refactoring the device explorer attributes subpanel I guess that's also related to #289

bltzr avatar May 17 '17 20:05 bltzr

To do :

In the DeviceExplorer{Model,View} (and certainly also the StateInspectorWidget), delegates that match the various data types should be created, following this tutorial : http://doc.qt.io/qt-5/model-view-programming.html#a-simple-delegate

This could also be used to make a specific delegate for the boolean type that would fix #89 .

jcelerier avatar May 31 '17 09:05 jcelerier