score icon indicating copy to clipboard operation
score copied to clipboard

Labels on timenodes with toggleable display

Open jcelerier opened this issue 8 years ago • 8 comments

jcelerier avatar Jul 04 '16 08:07 jcelerier

@bltzr so I added label displaying... however it seems that labels were already set to "TimeNode" by default for Timenode, so when loading a score now every TimeNode has a "TimeNode" text displayed next to it. Do you want me to add a quick if text == "TimeNode" then text.clear() for a few releases to remove them from the save files ? since I don't think this adds valuable information...

jcelerier avatar Jul 10 '16 08:07 jcelerier

good idea, thanks

bltzr avatar Jul 10 '16 11:07 bltzr

I was more thinking about a toggle button, by default on false, which would allow to display labels for some of the timenode.

pach avatar Jul 10 '16 12:07 pach

Because you’d want to have some nodes with labels, but undisplayed ?

bltzr avatar Jul 10 '16 15:07 bltzr

A display toggle button is not much more complex to implement than hiding the default name. And yes, it can be usefull to be able to display or not nodes labels. For exemple, during the creation, I do want labels on most nodes to know what is where. Then for the show, I would prefer to display label only for the trigged node and a few others.

pach avatar Jul 10 '16 17:07 pach

makes sense

bltzr avatar Jul 10 '16 19:07 bltzr

This implies :

  • Adding a "LabelShown" attribute to the ModelMetadata class.
  • Adding the information serialization in ModelMetadataSerialization.cpp
  • Creating a Command class similar to the one in ChangeElementLabel.hpp
  • Modifying MetadataWidget.cpp to show a little checkbox next to the label line (see around line 53) and send the command when it is checked

jcelerier avatar Oct 07 '16 15:10 jcelerier

This would be really usefull

reno- avatar Mar 04 '17 08:03 reno-