libossia icon indicating copy to clipboard operation
libossia copied to clipboard

unit time.midinote should rather be time.midipitch

Open vincentgoudard opened this issue 4 years ago • 4 comments

IMHO, this would be more accurate WRT to what a "MIDI note" is, i.e. a tuple with pitch, velocity and channel information.

Apparently, this is an heritage from Jamoma, so question is, to @jln- @bltzr @theod @lossius @matcham @reno- and other people counting on Jamoma patches : would that break too much thing for you to consider the change ?

Benefit is only the clarity for new Score users like me I guess, but we could be many ;)

vincentgoudard avatar Feb 06 '21 13:02 vincentgoudard

I think we can have alternative names to units in libossia (can you confirm, @jcelerier ?), so we could change this the way you say (which makes perfect sense) and still have people using the old syntax (and not breaking their patches)

bltzr avatar Feb 08 '21 10:02 bltzr

yep, adding it :) (would everyone be ok with also "pitch" as alias ?)

jcelerier avatar Feb 08 '21 10:02 jcelerier

works for me — the simpler the better :)

vincentgoudard avatar Feb 08 '21 10:02 vincentgoudard

doesn't break patches and makes Vincent happy, so I'm happy too :-)

matcham avatar Feb 08 '21 10:02 matcham