scorecard ✨ Add check ID

What kind of change does this PR introduce?

Enhancement to our structured results. Adds a static Check ID for all checks, along with updates to check validation process to make sure the ID is unique. Only impacts Json results.

I also ran fieldalignment on the files where I made changes to struct members.

[x] PR title follows the guidelines defined in our pull request documentation

What is the current behavior?

Json output only has name for identifying the check

{
    "details": null,
    "score": 10,
    "reason": "no binaries found in the repo",
    "name": "Binary-Artifacts",
    "documentation": {
        "url": "https://github.com/ossf/scorecard/blob/main/docs/checks.md#binary-artifacts",
        "short": "Determines if the project has generated executable (binary) artifacts in the source repository."
    }
},

What is the new behavior (if this is a feature change)?**

Adding a uint as a unique ID allows users to filter/search for checks without string comparison.

{
    "id": 3,
    "details": null,
    "score": 10,
    "reason": "no binaries found in the repo",
    "name": "Binary-Artifacts",
    "documentation": {
        "url": "https://github.com/ossf/scorecard/blob/main/docs/checks.md#binary-artifacts",
        "short": "Determines if the project has generated executable (binary) artifacts in the source repository."
    }
},

Which issue(s) this PR fixes

Fixes #2577

Special notes for your reviewer

Does this PR introduce a user-facing change?

Add Check ID

Apr 10 '24 23:04 ashearin

I think this change represents an interesting challenge for the cron, as it's something we could technically go and backfill data for. Can we wait on this until after OSS NA?

No rush from me, will do a bit more cleanup and we can look at it after next week

Apr 11 '24 22:04 ashearin

Note the linter we use currently is fieldalignment

Went back and reset the structs and ran fieldalignment on them.

Apr 12 '24 00:04 ashearin